Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[website] Make general improvements to the Material UI page #41075

Merged
merged 13 commits into from
Feb 15, 2024
Merged

[website] Make general improvements to the Material UI page #41075

merged 13 commits into from
Feb 15, 2024

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Feb 13, 2024 •
edited

This PR is an overall housekeeping to the Material UI page, fixing many separate minor design issues such as proper focus-visible style appearance, component demo standardization, icon changes, etc. The commits have been isolated as much as possible for ease of understanding of all additions.

Preview: https://deploy-preview-41075--material-ui.netlify.app/material-ui

@danilo-leal danilo-leal added design This is about UI or UX design, please involve a designer website Pages that are not documentation-related, marketing-focused. labels Feb 13, 2024
@danilo-leal danilo-leal self-assigned this Feb 13, 2024
@mui-bot
Copy link

mui-bot commented Feb 13, 2024 •
edited

Netlify deploy preview

https://deploy-preview-41075--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 1bf64e0

zanivan
zanivan reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement—especially on the component's focus ✨

Found just a bug on the Real Estate demo component, where the Chip's icon is misaligned.

Screenshot 2024-02-13 at 16 04 58

zanivan
zanivan reviewed Feb 14, 2024
View reviewed changes
Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the mobile version, some items have an unintentional horizontal scroll:

Screenshot 2024-02-14 at 14 59 17 Screenshot 2024-02-14 at 14 59 25 Screenshot 2024-02-14 at 15 00 27

zanivan
zanivan approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one more thing, not exactly related to this PR, though—so I'll leave my approval here if you want to tackle it in a different PR :)

Some code snippets are presenting two horizontal scrollbars on the mobile breakpoint:

Screenshot 2024-02-15 at 13 06 53 Screenshot 2024-02-15 at 13 07 01

@danilo-leal danilo-leal merged commit af07936 into mui:master Feb 15, 2024
19 checks passed
@danilo-leal danilo-leal deleted the improvements-material-ui-page branch February 15, 2024 16:14
@mbrookes mbrookes changed the title [website] Add overall improvements to the Material UI page [website] Make general improvements to the Material UI page Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanivan zanivan zanivan approved these changes

Assignees

@danilo-leal danilo-leal

Labels
design This is about UI or UX design, please involve a designer website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danilo-leal @mui-bot @zanivan