[code-infra] Move typescript-to-proptypes to internal-scripts package #41079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-41079--material-ui.netlify.app/ Bundle size report |
1 task
Janpot
reviewed
Feb 14, 2024
pnpm-workspace.yaml
Outdated
| @@ -5,3 +5,4 @@ packages: | |||
| - 'docs' | |||
| - 'test' | |||
| - 'apps/*' | |||
| - 'internal/*' | |||
There was a problem hiding this comment.
This is where we will collect al internal packages? i.e. all @mui/internal- packages?
There was a problem hiding this comment.
That's the idea. This could also be named internal-packages if you like, but internal matches the package prefix.
There was a problem hiding this comment.
👍 got it.
Up to you, I don't have a strong opinion on this. I we end up renaming it, I'd be more leaning towards packages-internal as that will place it next to the packages folder in the file explorer.
michaldudak
force-pushed
the
ttp-to-internal-scripts
branch
from
99dcea9
to
01931c2
Compare
Janpot
approved these changes
Feb 14, 2024
github-actions
bot
added
PR: out-of-date
|
I don't have a strong preference, so let it be |
michaldudak
force-pushed
the
ttp-to-internal-scripts
branch
from
0fd8ae0
to
299402d
Compare
|
MUI X integration: mui/mui-x#12142 |
michaldudak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created the @mui/internal-scripts package with its first subpackage: typescript-to-proptypes.