Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][StepLabel] Add type for StepIconComponent #41082

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

harrydigos
Copy link
Contributor

@harrydigos harrydigos commented Feb 13, 2024

This PR provides types for StepIconComponent.

Closes #41101

@mui-bot
Copy link

mui-bot commented Feb 13, 2024

Netlify deploy preview

https://deploy-preview-41082--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 0cc080c

@harrydigos harrydigos marked this pull request as draft February 13, 2024 19:51
@harrydigos harrydigos marked this pull request as ready for review February 13, 2024 19:52
@danilo-leal danilo-leal added package: material-ui Specific to @mui/material component: stepper This is the name of the generic UI component, not the React module! labels Feb 13, 2024
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harrydigos Is there already a GitHub issue you're working on? If not, could you please create a new issue with a CodeSandbox reproduction and provide the link here?

@ZeeshanTamboli ZeeshanTamboli added typescript enhancement This is not a bug, nor a new feature labels Feb 14, 2024
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][StepLabel] Add types for StepIconComponent [material-ui][StepLabel] Add type for StepIconComponent Feb 15, 2024
@ZeeshanTamboli ZeeshanTamboli merged commit 4b14966 into mui:master Feb 15, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: stepper This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature package: material-ui Specific to @mui/material typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui][StepLabel] Types for StepIconComponent does not exist
4 participants