Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Improve the footer's chip contrast #41209

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Feb 20, 2024

Aside from what the title says, I also added a new page under the Experiments directory that we can fill up more over time to visualize the brand-themed components. It'll likely be easier to maintain them and make changes without getting to pages where they're available. We should've done this a long time ago 馃槄

@danilo-leal danilo-leal added design This is about UI or UX design, please involve a designer website Pages that are not documentation-related, marketing-focused. labels Feb 20, 2024
@danilo-leal danilo-leal self-assigned this Feb 20, 2024
@mui-bot
Copy link

mui-bot commented Feb 20, 2024

Netlify deploy preview

https://deploy-preview-41209--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 馃毇 dangerJS against 95692b0

@zanivan
Copy link
Contributor

zanivan commented Feb 21, 2024

I also added a new page under the Experiments directory that we can fill up more over time to visualize the brand-themed components.

I wonder if we should come up with a storybook for the branding theme. This might also be useful as a learning resource for users, since it's one of the most common ways to document a DS. What do you think?

Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the error and warning variants should also have a background. It'd help with the contrast.

Screenshot 2024-02-21 at 12 50 16 Screenshot 2024-02-21 at 12 50 29

@danilo-leal
Copy link
Contributor Author

Potentially, yeah, a Storybook instance for the brand-themed components would certainly be interesting! I don't know whether we have that infrastructure at the moment, but I can look into it later. As for the error and warning chips, I didn't mess with them right because they're not used at the moment (though there are opportunities to make use of them where we're customing colors by hand instead of using the color prop). 馃

@danilo-leal danilo-leal merged commit 1f08a81 into mui:master Feb 21, 2024
19 checks passed
@danilo-leal danilo-leal deleted the website-contrast-improvements branch February 21, 2024 18:29
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants