[code-infra] Add alias for icon types #41248
Conversation
Netlify deploy previewhttps://deploy-preview-41248--material-ui.netlify.app/ Bundle size report |
Janpot
changed the title
| @@ -65,6 +65,22 @@ declare module '@mui/material/Chip' { | |||
| } | |||
| } | |||
|
|
|||
| declare module '@mui/material/SvgIcon' { | |||
There was a problem hiding this comment.
Had to add a few interface augmentations to make icons types work for joy (cc @siriwatknp)
| {Object.keys(theme.fontSize).map((size) => ( | ||
| <Person key={size} fontSize={size} /> | ||
| ))} | ||
| <Person fontSize="xs" /> |
There was a problem hiding this comment.
also cc @siriwatknp for suggesting a different solution if necessary
https://deploy-preview-41248--material-ui.netlify.app/joy-ui/integrations/icon-libraries/#size
|
It's all good from a Base UI perspective. I'll let @siriwatknp review the Joy UI changes as I don't know the original intent. |
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
github-actions
bot
removed
the
PR: out-of-date
| @@ -10,7 +10,7 @@ export default function TransitionComponentSnackbar() { | |||
| const [exited, setExited] = React.useState(true); | |||
| const nodeRef = React.useRef(null); | |||
|
|
|||
| const handleClose = (_: any, reason: SnackbarCloseReason) => { | |||
| const handleClose = (_: any, reason?: SnackbarCloseReason) => { | |||
There was a problem hiding this comment.
It's guaranteed to be defined, no?
| const handleClose = (_: any, reason?: SnackbarCloseReason) => { | |
| const handleClose = (_: any, reason: SnackbarCloseReason) => { |
There was a problem hiding this comment.
Not always, this is passed as a click handler to an SvgIcon. that's why it started failing when we added types for icons to the code base. Before, all icons were typed any and accepted this handler without warning.
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
Make sure we have types for icons across the monorepo. This is needed for #41206