Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[base-ui][FormControl] Export FormControlOwnerState type from index #41287

Merged
merged 4 commits into from Mar 5, 2024

Conversation

michaeldfoley
Copy link
Contributor

@michaeldfoley michaeldfoley commented Feb 27, 2024

Closes #41286

Signed-off-by: Michael Foley <michaeldfoley@gmail.com>
@mui-bot
Copy link

mui-bot commented Feb 27, 2024

Netlify deploy preview

https://deploy-preview-41287--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 135ca8d

@zannager zannager added the component: FormControl The React component label Feb 27, 2024
@danilo-leal danilo-leal added the package: base-ui Specific to @mui/base label Feb 29, 2024
@danilo-leal danilo-leal changed the title Export FormControlOwnerState type from index [base-ui] Export FormControlOwnerState type from index Feb 29, 2024
@danilo-leal danilo-leal changed the title [base-ui] Export FormControlOwnerState type from index [base-ui][FormControl] Export FormControlOwnerState type from index Feb 29, 2024
@ZeeshanTamboli ZeeshanTamboli added the bug 🐛 Something doesn't work label Mar 5, 2024
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaeldfoley Thanks for the PR. I've updated it to export all types from the .types.ts file, which is the preferred approach.

@ZeeshanTamboli ZeeshanTamboli merged commit 9f2ee3c into mui:master Mar 5, 2024
23 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 8, 2024
…mui#41287)

Signed-off-by: Michael Foley <michaeldfoley@gmail.com>
Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: FormControl The React component package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[base-ui][FormControl] Export FormControlOwnerState type from FormControl
5 participants