[mui-codemod] Fix merging of slotProps and componentProps #41323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-41323--material-ui.netlify.app/ Bundle size report |
sai6855
changed the title
sai6855
commented
Mar 1, 2024
| @@ -31,7 +31,7 @@ describe('@mui/codemod', () => { | |||
| const actual = transform( | |||
| { source: read('./test-cases/theme.actual.js') }, | |||
| { jscodeshift }, | |||
| { printOptions: { trailingComma: true } }, | |||
| { printOptions: { trailingComma: false } }, | |||
There was a problem hiding this comment.
codemod was transforming without trailing comma, so changed to false here. Hope it's not an issue
sai6855
changed the title
|
Hey @DiegoAndai can this PR be reviewed, this PR is blocking my other |
DiegoAndai
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Thanks for catching and fixing this @sai6855 🚀
Sorry for the delay in the review.
1 task
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If same slot is present in
slotPropsandcomponentProps, i'd expect codemod to mergecomponentPropsandslotPropswithslotPropstaking precedence but current codemod entirely removescomponentProps.slot. This PR fixes this bug