[material-ui][Select] Fix variant type

[sai6855]

closes #41401
closes #41356
closes #41375
closes #41410

• I have followed (at least) the PR section of the contributing guide.

[mui-bot]

Netlify deploy preview

https://deploy-preview-41405--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 62ce5b4

[DiegoAndai]

Thanks for working on this @sai6855, the change looks good for the problem it solves.

I wonder if you have thoughts about #41356. Any ideas on how to solve that?

[DiegoAndai]

This looks good @sai6855! #41401 and #41356 are fixed. For #41410, we're missing the error on line 64 of this playground:

If we don't fix that one, then I don't know how users will be able to wrap the Select component, which is a common use case.

There's another error on line 73 for which I couldn't find a fix, but we can accept that one as a TS limitation.

cc: @michaldudak

[sai6855]

@DiegoAndai #41410 is fixed now, i changed implementation by removing Variant argument entirely (it's causing more problems then solving) from Select and SelectProps and retained ability to add hiddenLabel prop to only filled variant.

I hope i covered all possbile scenarios in tests, but let me know if you see anything missing.

Also updated issues in PR description

[DiegoAndai]

Thanks, @sai6855, great work managing all those issues. I think this is the best solution. I agree that the Variant argument seems to be causing more problems than it fixes.

I would like to get @michaldudak's opinion on this before merging.

Also, I'll leave a comment at #39137 to see if people involved in that PR have any opinions about this change.

[ZeeshanTamboli]

Since I was involved in reviewing #39137, I also reviewed this PR. I hope you don't mind. The fixes seem good to me. Great job, @sai6855!

[michaldudak]

This is the kind of PR that I'm usually quite afraid to approve. It looks OK, I couldn't find anything suspicious, but I can't think of all the ways it will be used in the wild and all the potential ways in can break.

I give a green light based on what I'm able to anticipate currently.

[DiegoAndai]

This seems to me as the best step forward as well, given the amount of issues it closes which were created with the initial attempt at improving the variant type.

Good job @sai6855