Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pigment] Rename directories to match package names #41453

Merged
merged 1 commit into from Mar 12, 2024
Merged

[pigment] Rename directories to match package names #41453

merged 1 commit into from Mar 12, 2024

Conversation

brijeshb42
Copy link
Contributor

@brijeshb42 brijeshb42 commented Mar 11, 2024 •
edited

I have kept the pigment-react/README.md to link to the new directory.

Closes #41332

@brijeshb42 brijeshb42 added the package: pigment-css Specific to @pigment-css/* label Mar 11, 2024
@mui-bot
Copy link

mui-bot commented Mar 11, 2024 •
edited

Netlify deploy preview

https://deploy-preview-41453--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against ee13a96

oliviertassinari
oliviertassinari reviewed Mar 11, 2024
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks 👍

@brijeshb42 brijeshb42 enabled auto-merge (squash) March 11, 2024 18:37
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 12, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 12, 2024
siriwatknp
siriwatknp approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please recheck the CI, the rest looks good.

@brijeshb42 brijeshb42 merged commit 828f4da into mui:master Mar 12, 2024
21 checks passed
@brijeshb42 brijeshb42 deleted the pigment/rename-directory branch March 12, 2024 10:45
@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes package: pigment-css Specific to @pigment-css/*
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pigment-css][core] Use npm package name for folder name
4 participants
@brijeshb42 @mui-bot @oliviertassinari @siriwatknp