Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-infra] Add a feature list "component" #41484

Merged
merged 11 commits into from Mar 15, 2024
Merged

[docs-infra] Add a feature list "component" #41484

merged 11 commits into from Mar 15, 2024

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Mar 13, 2024 •
edited

Closes #41479
Preview: https://deploy-preview-41484--material-ui.netlify.app/experiments/docs/custom-components

<featureList>
-  Manages modal stacking when one-at-a-time just isn't enough.
-  Creates a backdrop, for disabling interaction below the modal.est
</featureList>

@danilo-leal danilo-leal added design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product labels Mar 13, 2024
@danilo-leal danilo-leal requested a review from a team March 13, 2024 16:16
@danilo-leal danilo-leal self-assigned this Mar 13, 2024
@mui-bot
Copy link

mui-bot commented Mar 13, 2024 •
edited

Netlify deploy preview

https://deploy-preview-41484--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against d329b04

@alexfauquette
Copy link
Member

I've implemented the option 3. I'm okay to go with this option too

@danilo-leal
Copy link
Contributor Author

@alexfauquette yeah, me too! Thanks for doing it 🙏 I've deleted the other options and kept just that one. Good to go?

alexfauquette
alexfauquette approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me, but I'm kind of the PR author for the markdown aspect 😅

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 15, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 15, 2024
@danilo-leal danilo-leal merged commit 7d3b5a5 into mui:master Mar 15, 2024
22 checks passed
@danilo-leal danilo-leal deleted the add-feature-list-component branch March 15, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees

@danilo-leal danilo-leal

Labels
design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs-infra] Create a feature list/highlights component
4 participants
@danilo-leal @mui-bot @alexfauquette @siriwatknp