Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui] Standardize event handler callbacks #41925

Open
DiegoAndai opened this issue Apr 16, 2024 · 0 comments
Open

[material-ui] Standardize event handler callbacks #41925

DiegoAndai opened this issue Apr 16, 2024 · 0 comments
Labels
enhancement This is not a bug, nor a new feature package: material-ui Specific to @mui/material

Comments

@DiegoAndai
Copy link
Member

DiegoAndai commented Apr 16, 2024

Review, design, and standardize the event handler callback signatures across the library.

Some are marked to be modified: https://github.com/mui/material-ui/blob/next/packages/mui-material/src/internal/SwitchBase.js#L116-L119

While others aren't: https://github.com/mui/material-ui/blob/next/packages/mui-material/src/Select/SelectInput.js#L258

With the Base UI refactor on the horizon, this issue should be handled alongside it, as it will be tightly related. For example, while working on #40210, one of the blockers was that the Select component's onChange second argument was not supported by Base UI.

Overall, we should decide the optimal way to support custom callback signatures or if we should only rely on events API.

Search keywords:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature package: material-ui Specific to @mui/material
Projects
None yet
Development

No branches or pull requests

1 participant