Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][material-ui] Fix slider in color customization playground twitches when sliding #42119

Open
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

Nashyn
Copy link

@Nashyn Nashyn commented May 3, 2024

Fixes #42019

There were conflicting css issues that was preventing the slider from working smoothly when going from left to right or right to left and causing twitch after 100 and 50.

The issue is now solved as shown in the video below:

Twitch_issue_fixed.mp4

@mui-bot
Copy link

mui-bot commented May 3, 2024

Netlify deploy preview

https://deploy-preview-42119--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against b5ce5b0

@zannager zannager added docs Improvements or additions to the documentation component: slider This is the name of the generic UI component, not the React module! labels May 6, 2024
@zannager zannager requested a review from mj12albert May 6, 2024 16:19
@Nashyn
Copy link
Author

Nashyn commented May 10, 2024

@mj12albert can you please look at the changes whenever you get a chance.

@mj12albert mj12albert self-assigned this May 13, 2024
@mj12albert
Copy link
Member

@mj12albert can you please look at the changes whenever you get a chance.

@Nashyn Thanks for working on this! I will review this today

@mj12albert mj12albert removed the component: slider This is the name of the generic UI component, not the React module! label May 13, 2024
@mj12albert
Copy link
Member

@Nashyn Your changes does indeed fix the issue 👍

Just wondering how you found the fix and if you have tried other alternatives - it would be preferable if this could be fixed without using magic numbers ~

@Nashyn
Copy link
Author

Nashyn commented May 13, 2024

@mj12albert I found the fix while inspecting and trying roundabouts with slider css and saw a twitch was occuring due to conflicting styles. I have committed the changes you asked for if the solution works without magic number. Can you please review it. Thank you.

Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nashyn Thanks for the pull request.

There were conflicting css issues that was preventing the slider from working smooth

Could you explain what were the conflicting CSS styles, and how does wrapping Typography in a div resolve the issue?

@ZeeshanTamboli ZeeshanTamboli added the package: material-ui Specific to @mui/material label May 21, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [docs][customization-color] Slider twitch issue solved [docs][material-ui] Fix slider in color customization playground twitches when sliding May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs][material-ui] Slider in color customization playground twitches when sliding
5 participants