Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Figma] Bulk Actions #169

Open
2 tasks done
ivanbachev opened this issue Mar 15, 2023 · 2 comments
Open
2 tasks done

[Figma] Bulk Actions #169

ivanbachev opened this issue Mar 15, 2023 · 2 comments
Assignees
Labels
component: table This is the name of the generic UI component, not the React module! figma

Comments

@ivanbachev
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

What are the recommended guidelines on bulk selection in the Table and DataGrid components and shouldn’t there be dedicated components for a bulk selection bar _(similar to the dedicated toolbar “Custom / Table / Toolbar” component)?

Currently there are two “bulk actions” examples available in the Figma ui kit for the Table component:

  • “Data table: bulk actions 1” - this one uses a “” component with overrides
    Data table_ bulk actions 1

  • “Data table: bulk actions 2” - this is just set with an auto-layout group, but the first table head component should show with an indeterminate checkbox selection (to indicate 3 of the rows are selected and clicking on the indeterminate checkbox deselects the rows)
    Data table_ bulk actions 2

There are no examples provided for how bulk selection works on the “Data Grid” component.

The online documentation is also limited. I was only able to find this example https://mui.com/material-ui/react-table/#sorting-amp-selecting, which looks right but differs from the examples shown in the Figma UI kit.

[Screen Shot 2023-03-15 at 12 16 55](https://mui.com/material-ui/react-table/#sorting-amp-selecting)

Examples 🌈

I would personally recommend the Carbon Design System solution for covering the toolbar as this prevents the user from searching or filtering while the bulk actions are active.
https://carbondesignsystem.com/components/data-table/usage#multi-select-and-batch-action
https://react.carbondesignsystem.com/?path=/story/components-datatable-batch-actions--default

Motivation 🔦

My personal opinion is that there must be a consistency between the Table and DataGrid component regarding handling bulk actions. I would say a dedicated “Bulk Actions” component is need in the UI kit, with variants for Text and Icon buttons, "Cancel" action to clear the selection and etc.

@ivanbachev ivanbachev added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Mar 15, 2023
@zannager zannager added the figma label Mar 15, 2023
@oliviertassinari
Copy link
Member

Interesting question. I'm not aware that we have a story for this, so far, we leave this to the realm of the product designers that build with the components, cc @gerdadesign in guess you would like to recommend a specific solution.

@oliviertassinari oliviertassinari added the component: table This is the name of the generic UI component, not the React module! label Mar 15, 2023
@adrianmanea
Copy link
Collaborator

I also noticed this issue, and you are correct. There should be a defined way of doing bulk actions, at least out-of-the-box. That's why I have designed two concepts. People can try them out since a standard one is not available in the API. I think the one from the documentation is also custom created, correct?

@oliviertassinari oliviertassinari removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: table This is the name of the generic UI component, not the React module! figma
Projects
None yet
Development

No branches or pull requests

4 participants