Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[figma] Add the "tree data" feature to the Data Grid #331

Open
olivier-g74 opened this issue Apr 10, 2024 · 6 comments
Open

[figma] Add the "tree data" feature to the Data Grid #331

olivier-g74 opened this issue Apr 10, 2024 · 6 comments
Assignees
Labels
component: data grid This is the name of the generic UI component, not the React module! figma

Comments

@olivier-g74
Copy link

olivier-g74 commented Apr 10, 2024

Steps to reproduce

Link to live example: (required)

Steps:

  1. Checked the TreeView as presented in https://mui.com/x/react-data-grid/tree-data/
  2. Purchased the latest Design Kit for Figma 5.16.0 at https://mui.com/store/items/figma-react/
  3. Looked for the component in the section Data Grid: rows

Current behavior

The component for TreeView is missing

Expected behavior

I would like to have, like it is available fro Row Grouping feature, a component for TreeView

Context

Leverage tree view without having to detach the instance of Row Grouping and change it to mimic Tree View

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: DataGrid, TreeView
Order ID: Our MUI PRO Project License is purchased by BRZ Austria

Search keywords:

@olivier-g74 olivier-g74 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Apr 10, 2024
@michelengelen
Copy link
Member

@danilo-leal are you handling the design kits?

@michelengelen michelengelen added the support: question Community support but can be turned into an improvement label Apr 11, 2024
@michelengelen
Copy link
Member

@olivier-g74 are you referring to the tree data feature?
Just asking because we also have a package called TreeView! :D

@michelengelen michelengelen changed the title [DataGrid Figma Design Kit] Data Grid - Tree data (section Group&Pivot Pro version) [data grid] Figma Design Kit - Tree data missing Apr 11, 2024
@olivier-g74
Copy link
Author

Hi @michelengelen ,

My bad - I mentioned Tree view where I meant Tree data.

In the Data Grid feature presentation section Group & Pivot, sub-section Tree data (https://mui.com/x/react-data-grid/tree-data/) you can find a demo for a table with a hierarchy but this is missing from the Design kit, incl latest version 5.16.0
This Pro feature is similar to the Premium feature Row grouping but with a clear limitation for the former: Parents and children in the table share the exact same column headers.

Could you please release a dedicated component in the Design kit for the Tree data in Data Grid, not at all the Tree View (sorry for the confusion) in the name.

@danilo-leal danilo-leal transferred this issue from mui/mui-x Apr 11, 2024
@danilo-leal danilo-leal changed the title [data grid] Figma Design Kit - Tree data missing [figma] Add the "tree data" feature to the Data Grid Apr 11, 2024
@danilo-leal danilo-leal added figma component: data grid This is the name of the generic UI component, not the React module! and removed support: question Community support but can be turned into an improvement status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Apr 11, 2024
@danilo-leal
Copy link

Heya — thanks for the shoutout @michelengelen! I moved this issue over to the design-kits repo so we can better track it in the context of the Design Kits. We can try to push this one out for the next version.

@olivier-g74
Copy link
Author

Can you please note that the Cell 1 that contains the chevron and the Goup name is currently "Align top left" and not "Align left" like the rest of the cells, so when you switch Density of lines from Standard to Compact or Comfortable, it creates an undesired padding.
image
image
image

@adrianmanea
Copy link
Collaborator

Noted! We'll do some tests for this case, but it's rather hard to maintain order with so many variables in place (especially undetached). What we recommend is to see these as starting points and undetach and manually adjust Cells.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! figma
Projects
None yet
Development

No branches or pull requests

4 participants