Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Running yarn in tools-public throws on Windows #101

Open
mnajdova opened this issue May 16, 2023 · 2 comments
Open

[bug] Running yarn in tools-public throws on Windows #101

mnajdova opened this issue May 16, 2023 · 2 comments
Labels
bug 🐛 Something doesn't work

Comments

@mnajdova
Copy link
Member

Navigate to tools-public and run yarn. I got the following error:

[5/5] Building fresh packages...
[-/4] ⠐ waiting...
[2/4] ⠈ esbuild
[3/4] ⠈ cpu-features
warning Error running install script for optional dependency: "D:\\workspace\\mui-public\\tools-public\\node_modules\\cpu-features: Command failed.
Exit code: 1
Command: node buildcheck.js > buildcheck.gypi && node-gyp rebuild
Arguments:
Directory: D:\\workspace\\mui-public\\tools-public\\node_modules\\cpu-features
Output:
D:\\workspace\\mui-public\\tools-public\\node_modules\\buildcheck\\lib\\index.js:133
        throw new Error('Unable to detect compiler type');
        ^

Error: Unable to detect compiler type
    at new BuildEnvironment (D:\\workspace\\mui-public\\tools-public\\node_modules\\buildcheck\\lib\\index.js:133:15)
    at Object.<anonymous> (D:\\workspace\\mui-public\\tools-public\\node_modules\\cpu-features\\buildcheck.js:5:12)
    at Module._compile (node:internal/modules/cjs/loader:1191:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1245:10)
    at Module.load (node:internal/modules/cjs/loader:1069:32)
    at Function.Module._load (node:internal/modules/cjs/loader:904:12)
warning Your current version of Yarn is out of date. The latest version is "1.22.19", while you're on "1.22.5".
info To upgrade, download the latest installer at "https://yarnpkg.com/latest.msi".
Done in 360.69s.

OS used: Windows
yarn version: 1.22.5


I could still do yarn dev and run it locally, haven't noticed some issues.

@Janpot
Copy link
Member

Janpot commented May 16, 2023

Looks like it gets pulled in through ssh2. It seems to be an optional dependency. It says warning, and the install command finished with a 0 exit code, so I assume the installation went fine and this can just be ignored. If ssh2 marks this as optional I guess it will detect whether the installation happened correctly before using the dependency.

@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label May 18, 2023
@Janpot
Copy link
Member

Janpot commented May 24, 2023

@mnajdova When you have a moment, could you try on the latest master? I've updated the transitive dependencies. I noticed they recently had some updates around windows support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

No branches or pull requests

3 participants