Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Migrate CircleCI from GitHub OAuth to GitHub App #153

Open
oliviertassinari opened this issue Mar 31, 2024 · 0 comments
Open
Labels
on hold There is a blocker, we need to wait scope: code-infra Specific to the core-infra product waiting for 👍 Waiting for upvotes

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 31, 2024

Summary

https://circleci.com/docs/github-apps-integration/ CircleCI’s GitHub App integration provides fine-grained permissions. It's strange for a member on the Base UI team to be able to change profoundly the config of MUI X. As we grow, moving in this direction would make more sense. Well, unless we decide to to consolidate on another CI, but I don't see clear problems with CircleCI today, it seems good enough: https://www.notion.so/mui-org/code-infra-Migrate-out-of-CircleCI-42350363b7344380a9961cf9731aae31.

See the guide for the migration https://circleci.com/docs/github-apps-integration/#Moving-from-github-oauth-app-to-github-app.

However, the list of not yet supported features feels like a deal-breaker: https://circleci.com/docs/github-apps-integration/#currently-not-supported

  • Cancel redundant builds
  • Scheduled pipelines
  • Stop building
  • Passing secrets to forked pull requests
  • Manual trigger pipeline option

Examples

No response

Motivation

No response

Search keywords: -

@oliviertassinari oliviertassinari added status: waiting for maintainer These issues haven't been looked at yet by a maintainer scope: code-infra Specific to the core-infra product waiting for 👍 Waiting for upvotes on hold There is a blocker, we need to wait and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold There is a blocker, we need to wait scope: code-infra Specific to the core-infra product waiting for 👍 Waiting for upvotes
Projects
None yet
Development

No branches or pull requests

1 participant