Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code components] Support building components with adjustable height #3332

Open
Janpot opened this issue Mar 26, 2024 · 1 comment
Open

[code components] Support building components with adjustable height #3332

Janpot opened this issue Mar 26, 2024 · 1 comment
Labels
new feature New feature or request waiting for 👍 Waiting for upvotes

Comments

@Janpot
Copy link
Member

Janpot commented Mar 26, 2024

Summary

It should be possible for code components to be height adjustable, just like the built-in Chart/DataGrid. Perhaps the component definition could support a verticallyResizable property or something?

Examples

No response

Motivation

I'm trying to build a custom variant of the DataGrid, but I can't achieve feature parity to the built-in DataGrid because I can't make it vertically resizable

Search keywords: code component height

@Janpot Janpot added new feature New feature or request waiting for 👍 Waiting for upvotes labels Mar 26, 2024
@apedroferreira
Copy link
Member

apedroferreira commented Mar 26, 2024

I may not have realized by adding this change

that I made it so that it's not possible to make a custom component vertically resizable...

An easy first step would be to replace this component whitelist with an opt-in prop, as you said - actually this list of components inside a component wasn't a great solution...
Besides that we can definitely discuss this whole topic more deeply - I was working on improving vertical resizing but it still had some difficult bugs/issues and so it needs some more time/work dedicated to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request waiting for 👍 Waiting for upvotes
Projects
None yet
Development

No branches or pull requests

2 participants