[docs][Charts] Give a general revision to the docs #11249
Merged
+290
−153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
docs
danilo-leal
requested review from
flaviendelangle,
alexfauquette and
mapache-salvaje
|
A similar effort has already been merged on master and is cherry-picked on next #11239. So some conflict might be expected Especially on the nav bar structure, and the introduction page |
|
@alexfauquette, should I wait for you to finish/merge that other PR? Any recommendations? 😬 |
|
The other PR is ready to be merged. It's a cherry-pick of another PR that has already been accepted |
|
Ok, I'll wait for that and then resolve any conflicts with this one! |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
|
@flaviendelangle + @alexfauquette can y'all take a second look at this when possible? 😃 |
oliviertassinari
added a commit
that referenced
this pull request
Jan 3, 2024
A quick fix on top of #11249.
| title: 'Bar Chart', | ||
| srcLight: '/static/x/component-illustrations/bar-light.png', | ||
| srcDark: '/static/x/component-illustrations/bar-dark.png', | ||
| href: '/x/react-charts/bar/', |
There was a problem hiding this comment.
Oops https://next.mui.com/x/react-charts/bar/
Fixed in 1a131e0.
oliviertassinari
pushed a commit
that referenced
this pull request
Jan 5, 2024
oliviertassinari
added a commit
that referenced
this pull request
Jan 5, 2024
A quick fix on top of #11249.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives a general revision to the MUI X Charts space, proposing changes such as:
👉 https://deploy-preview-11249--material-ui-x.netlify.app/x/react-charts/