Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[support-infra] Replace author association with a permission check in survey action #12068

Merged

Conversation

michelengelen
Copy link
Member


Since users who did not make it public that they belong to the org still got the survey message I changed the approach to checking the user-permission on the repo instead. If permission of 'write' or 'admin' is present (org member) don't show the appendix.

@michelengelen michelengelen added the scope: infra Org infrastructure work going on behind the scenes label Feb 15, 2024
@michelengelen michelengelen self-assigned this Feb 15, 2024
@mui-bot
Copy link

mui-bot commented Feb 15, 2024

Deploy preview: https://deploy-preview-12068--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 556b54a

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 25, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 26, 2024
@michelengelen michelengelen changed the title [infra] Replaced author association with a permission check in survey action [support-infra] Replaced author association with a permission check in survey action Apr 3, 2024
@michelengelen michelengelen changed the base branch from next to master April 3, 2024 13:17
@michelengelen michelengelen requested review from MBilalShafi and LukasTy and removed request for joserodolfofreitas and oliviertassinari April 3, 2024 13:18
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, LGTM. 👌

@LukasTy LukasTy changed the title [support-infra] Replaced author association with a permission check in survey action [support-infra] Replace author association with a permission check in survey action Apr 3, 2024
@michelengelen michelengelen merged commit 818dd12 into mui:master Apr 3, 2024
17 checks passed
@michelengelen michelengelen deleted the automation/token-permissions branch April 3, 2024 13:54
joakimtveter pushed a commit to joakimtveter/mui-x that referenced this pull request Jun 6, 2024
… survey action (mui#12068)

Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: infra Org infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants