[charts] Allow to skip animation on sparkline bar #12160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
added
regression
|
Deploy preview: https://deploy-preview-12160--material-ui-x.netlify.app/ Updated pages: |
LukasTy
approved these changes
Feb 21, 2024
| @@ -101,6 +101,12 @@ export interface SparkLineChartProps | |||
| * } | |||
| */ | |||
| margin?: Partial<CardinalDirections<number>>; | |||
| /** | |||
| * If `true`, bar animations are skiped. | |||
| * @deprecated In v7 animation are skiped for sparkline. | |||
There was a problem hiding this comment.
Suggested change
| * @deprecated In v7 animation are skiped for sparkline. | |
| * @deprecated In v7 animations are skipped for sparkline. |
There was a problem hiding this comment.
by default.
It's not exactly by default, they are just removed, assuming nobody needs it. We could add a props enableAnimation in v7 but for now it does not exist
There was a problem hiding this comment.
Gotcha. Updated the suggestion. 😉
There was a problem hiding this comment.
It was mostly to make sure you are not choked that v7 removes this feature ;)
Yes but this feature will be removed in a month, and the feature is in the API of the component |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12152
The bar animation has been added by error in sparkline with #9926 in the v6.0.0-alpha.16.
For v7 it has been removed by #11311
Since the behavior is here since the beginning of v6.0.0 I propose to add the
skipAnimationprops to sparkline to keep the same default as before, and keep v7 as it is