Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPremium] Add support for confirmation before clipboard paste #12225

Merged
merged 9 commits into from
Mar 15, 2024
Merged

[DataGridPremium] Add support for confirmation before clipboard paste #12225

merged 9 commits into from
Mar 15, 2024

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Feb 27, 2024 •
edited

@cherniavskii cherniavskii added component: data grid This is the name of the generic UI component, not the React module! plan: Premium Impact at least one Premium user customization: extend Logic customizability enhancement This is not a bug, nor a new feature feature: Clipboard Related to clipboard copy or paste functionalities labels Feb 27, 2024
@mui-bot
Copy link

mui-bot commented Feb 27, 2024 •
edited

Deploy preview: https://deploy-preview-12225--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 1d73ede

@cherniavskii cherniavskii mentioned this pull request Feb 27, 2024
Closed
@cherniavskii cherniavskii changed the title [DataGridPremium] Allow support for confirmation before clipboard paste [DataGridPremium] Add support for confirmation before clipboard paste Feb 27, 2024
@cherniavskii cherniavskii marked this pull request as ready for review February 28, 2024 11:26
@cherniavskii cherniavskii added the needs cherry-pick The PR should be cherry-picked to master after merge label Feb 28, 2024
MBilalShafi
MBilalShafi approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce addition to the clipboard paste feature 🎉

docs/data/data-grid/clipboard/clipboard.md Outdated Show resolved Hide resolved
packages/x-data-grid-premium/src/models/dataGridPremiumProps.ts Outdated Show resolved Hide resolved
MBilalShafi
MBilalShafi approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@cherniavskii cherniavskii enabled auto-merge (squash) March 15, 2024 21:35
@cherniavskii cherniavskii merged commit 3003314 into mui:next Mar 15, 2024
15 checks passed
@cherniavskii cherniavskii deleted the onClipboardPasteBeforeStart branch March 15, 2024 21:51
cherniavskii added a commit to cherniavskii/mui-x that referenced this pull request Mar 15, 2024
@cherniavskii
[DataGridPremium] Add support for confirmation before clipboard paste (…
9de7603 
…mui#12225)
@cherniavskii cherniavskii mentioned this pull request Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBilalShafi MBilalShafi MBilalShafi approved these changes

@michelengelen michelengelen michelengelen approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! customization: extend Logic customizability enhancement This is not a bug, nor a new feature feature: Clipboard Related to clipboard copy or paste functionalities needs cherry-pick The PR should be cherry-picked to master after merge plan: Premium Impact at least one Premium user v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] How to do confirmation before pasting?
4 participants
@cherniavskii @mui-bot @MBilalShafi @michelengelen