Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPremium] Fix boolean cell not rendered in group rows #12492

Merged
merged 7 commits into from
Mar 21, 2024
Merged

[DataGridPremium] Fix boolean cell not rendered in group rows #12492

merged 7 commits into from
Mar 21, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Mar 19, 2024 •
edited

@sai6855 sai6855 marked this pull request as draft March 19, 2024 09:57
@sai6855 sai6855 added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Row grouping Related to the data grid Row grouping feature labels Mar 19, 2024
@mui-bot
Copy link

mui-bot commented Mar 19, 2024 •
edited

Deploy preview: https://deploy-preview-12492--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against bea9cbf

@sai6855 sai6855 marked this pull request as ready for review March 19, 2024 11:36
sai6855
sai6855 commented Mar 19, 2024
View reviewed changes
packages/x-data-grid/src/components/cell/GridBooleanCell.tsx
@@ -140,7 +140,7 @@ const GridBooleanCell = React.memo(GridBooleanCellRaw);
export { GridBooleanCell };

export const renderBooleanCell: GridColDef['renderCell'] = (params: GridBooleanCellProps) => {
if (isAutoGeneratedRow(params.rowNode)) {
if (params.field !== '__row_group_by_columns_group__' && isAutoGeneratedRow(params.rowNode)) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated logic doesn't show any content if row is autogenerated and row is not grouped by that column.

@MBilalShafi MBilalShafi changed the base branch from next to master March 21, 2024 02:18
@cherniavskii cherniavskii added the plan: Premium Impact at least one Premium user label Mar 21, 2024
cherniavskii
cherniavskii approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cherniavskii cherniavskii changed the title [DataGrid] Fix display of isFilled icon of row grouping [DataGridPremium] Fix boolean cell not rendered in group rows Mar 21, 2024
@cherniavskii cherniavskii added the CLA: signed See https://www.notion.so/mui-org/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 label Mar 21, 2024
@cherniavskii cherniavskii merged commit fb7e03e into mui:master Mar 21, 2024
15 checks passed
joakimtveter pushed a commit to joakimtveter/mui-x that referenced this pull request Jun 6, 2024
@sai6855 @cherniavskii @joakimtveter
[DataGridPremium] Fix boolean cell not rendered in group rows (mui#12492
d13ec95 
)

Co-authored-by: Andrew Cherniavskyi <andrew@mui.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

@flaviendelangle flaviendelangle Awaiting requested review from flaviendelangle

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work CLA: signed See https://www.notion.so/mui-org/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 component: data grid This is the name of the generic UI component, not the React module! feature: Row grouping Related to the data grid Row grouping feature plan: Premium Impact at least one Premium user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Row grouping on checkbox field does not render value
3 participants
@sai6855 @mui-bot @cherniavskii