[docs] Sync static images from core repository #12525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-12525--material-ui-x.netlify.app/ |
alexfauquette
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Looks like those two are unused. At least I don't see them used in the material-ui repo
@danilo-leal could it be WIP images that has not be deleted?
- marblism-square.png
- marblism-rectangular.svg
In production we don't need it, because the path mui.com/static/ leads to the content of the core repo. But I've no idea about how we could reproduce this behavior in preview
|
All good for me. I'd keep the svgs, though, and just take out the png for the Marablism logo. |
|
Thanks, I've removed the PNGs added in this PR as they did not seem to be used. 🙈 🤷 |
cherniavskii
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes missing resources on docs preview deploys.