Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DateTimeRangePicker] Fix views behavior regression #12529

Merged

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Mar 21, 2024

Fixes a regression where on mobile after selecting start time the view switches to end time instead of end date.

Caused by https://github.com/mui/mui-x/pull/12441/files#diff-3486b9e595ab1f393c7d593c337d48b0dfcde196e3d1f2b0fc641bba34f895abR108

Unblocking the release for now.
Will investigate why the test was not failing locally and reliably and how to make the view switching less fragile.

@LukasTy LukasTy added regression A bug, but worse component: pickers This is the name of the generic UI component, not the React module! component: DateTimeRangePicker The React component labels Mar 21, 2024
@LukasTy LukasTy self-assigned this Mar 21, 2024
@mui-bot
Copy link

mui-bot commented Mar 21, 2024

Deploy preview: https://deploy-preview-12529--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against a793d57

@LukasTy LukasTy enabled auto-merge (squash) March 21, 2024 14:57
@LukasTy LukasTy disabled auto-merge March 21, 2024 15:18
@LukasTy LukasTy merged commit dcb8721 into mui:master Mar 21, 2024
15 checks passed
@LukasTy LukasTy deleted the fix-mobile-date-time-range-picker-views-behavior branch March 21, 2024 15:19
joakimtveter pushed a commit to joakimtveter/mui-x that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: DateTimeRangePicker The React component component: pickers This is the name of the generic UI component, not the React module! regression A bug, but worse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants