Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] Improve Chinese (Hong Kong) (zh-HK) locale #12547

Merged
merged 5 commits into from Mar 26, 2024
Merged

[l10n] Improve Chinese (Hong Kong) (zh-HK) locale #12547

merged 5 commits into from Mar 26, 2024

Conversation

samchiu90
Copy link
Contributor

@samchiu90 samchiu90 commented Mar 25, 2024 •
edited

@mui-bot
Copy link

mui-bot commented Mar 25, 2024 •
edited

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running yarn l10n
  • Clean files with yarn prettier.

Deploy preview: https://deploy-preview-12547--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 7952309

@LukasTy LukasTy added l10n localization component: pickers This is the name of the generic UI component, not the React module! labels Mar 25, 2024
@LukasTy LukasTy changed the title [l10n] Update Chinese (Hong Kong) (zh-HK) locale in x-date-pickers [l10n] Improve Chinese (Hong Kong) (zh-HK) locale Mar 25, 2024
LukasTy
LukasTy approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your time! 🙏
Strangely, there still was a prettier error.
I took the liberty to push a fix to your branch. 🙈 😉

@LukasTy LukasTy enabled auto-merge (squash) March 26, 2024 06:06
@LukasTy LukasTy merged commit 6034acf into mui:master Mar 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

Assignees
No one assigned
Labels
component: pickers This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samchiu90 @mui-bot @LukasTy