[fields] Fix placeholder override #12589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
regression
flaviendelangle
force-pushed
the
placeholder-override
branch
from
9e1f1be
to
087c82e
Compare
|
Deploy preview: https://deploy-preview-12589--material-ui-x.netlify.app/ |
LukasTy
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Hehe, was looking at the same problem, just didn't assign myself before validating the regression. 👌
P.S. It clearly wouldn't hurt having a test for it. 🙈
However, I'm not sure if we can support it for the "v7" accessible fields 🤷 Even the native <input type="date" /> element doesn't. 🤔
😆 Assignment is key I will add a quick test for the v6. |
|
I added a test for both the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12573