[core] Use PR labels to identify the package a l10n PR belongs to
#12639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-12639--material-ui-x.netlify.app/ |
romgrk
approved these changes
Apr 2, 2024
alexfauquette
approved these changes
Apr 3, 2024
A message in x slack channel could help on getting every body taking care of that 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the problem with incorrectly placed
l10nandi18nPRs.They are now being always assumed to belong to the
DataGridpackage, whereaspickersprobably receives even morel10ncontributions.We are already fetching information about every PR.
I've added extra logic to use the labels added to a certain PR to put the PR message in the correct package.
Important
This relies on us assigning a correct package label on any
l10nori18nPR.