Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Adds a recipe for the checkboxSelectionVisibleOnly prop #12646

Merged
merged 4 commits into from
Apr 4, 2024
Merged

[docs] Adds a recipe for the checkboxSelectionVisibleOnly prop #12646

merged 4 commits into from
Apr 4, 2024

Conversation

michelengelen
Copy link
Member

This adds a new demo to the selection page in the docs to show the behaviour of the checkboxSelectionVisibleOnly prop.

This came up in #12625

@michelengelen michelengelen added docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! needs cherry-pick The PR should be cherry-picked to master after merge recipe labels Apr 3, 2024
@mui-bot
Copy link

mui-bot commented Apr 3, 2024 •
edited

Deploy preview: https://deploy-preview-12646--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against a7478ce

michelengelen and others added 2 commits April 3, 2024 12:22
@michelengelen @cherniavskii
Apply suggestions from code review
37d1123 
Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
@michelengelen
applied review remarks and added pagination to the demo
b09c4d0
MBilalShafi
MBilalShafi approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice addition, thank you 🎉

docs/data/data-grid/row-selection/row-selection.md Outdated Show resolved Hide resolved
@michelengelen michelengelen merged commit e42a1cf into mui:master Apr 4, 2024
2 of 5 checks passed
@michelengelen michelengelen deleted the docs/12625 branch April 4, 2024 06:26
github-actions bot pushed a commit that referenced this pull request Apr 4, 2024
@michelengelen @cherniavskii @web-flow
[docs] Adds a recipe for the checkboxSelectionVisibleOnly prop (#12646
40ddb15 
)

Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
@github-actions github-actions bot mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBilalShafi MBilalShafi MBilalShafi approved these changes

@cherniavskii cherniavskii cherniavskii approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation needs cherry-pick The PR should be cherry-picked to master after merge recipe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michelengelen @mui-bot @MBilalShafi @cherniavskii