[core] Add cherry-pick master to v6 action
#12648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-12648--material-ui-x.netlify.app/ |
| permissions: | ||
| pull-requests: write | ||
| contents: write | ||
| if: ${{ contains(github.event.pull_request.labels.*.name, 'needs cherry-pick') && contains(github.event.pull_request.labels.*.name, 'v6.x') && github.event.pull_request.merged == true }} |
There was a problem hiding this comment.
do we really need the v6.x label? Seems like 99.9% of PRs will be on master and when a cherry pick is needed we only add it to v6 anyways, right?
There was a problem hiding this comment.
No, technically we don't need it.
I've added the extra check just to have the maximum specificity.
If we agree, then it could just be the same as for next -> master, simply adding a needs cherry-pick label would cherry-pick the PR to v6.x.
There was a problem hiding this comment.
IMHO I would be in favor of that
There was a problem hiding this comment.
Removed the extra check. 😉
michelengelen
approved these changes
Apr 3, 2024
cherniavskii
approved these changes
Apr 3, 2024
MBilalShafi
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an action, which would cherry-pick a PR merged to master into a
v6.xbranch if it would have aneeds cherry-picklabel.Could be useful for bug fixes during the v7 development / v6 maintenance mode.