Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Limit test-types CI step allowed memory #12651

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Apr 3, 2024

This is a continuation of #8796.

We again started occasionally seeing 137 errors: https://app.circleci.com/pipelines/github/mui/mui-x/55996/workflows/3785ca42-1a35-41fb-945a-6672ab60ff50/jobs/320388/steps

I assume that the memory limit applies to a single node instance.
Given that Lerna runs 3 concurrent instances at a single point in time, it would mean that theoretically we currently allow a maximum of 9GB of RAM to be used. 馃檲

It doesn't seem to impact the step runtime in a significant way that couldn't be attributed to a difference between runs:

Before After
Screenshot 2024-04-03 at 17 52 28 Screenshot 2024-04-03 at 17 52 19
https://app.circleci.com/pipelines/github/mui/mui-x/56008/workflows/c845e1fa-28a7-44bf-8d98-a93a4705ae36/jobs/320441/steps https://app.circleci.com/pipelines/github/mui/mui-x/56001/workflows/74d23679-f599-4320-a60d-30b0d195376f/jobs/320419/steps

@LukasTy LukasTy added the core Infrastructure work going on behind the scenes label Apr 3, 2024
@LukasTy LukasTy self-assigned this Apr 3, 2024
@mui-bot
Copy link

mui-bot commented Apr 3, 2024

Deploy preview: https://deploy-preview-12651--material-ui-x.netlify.app/

Generated by 馃毇 dangerJS against 81dcf42

@LukasTy LukasTy requested review from michelengelen and a team April 3, 2024 14:48
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, every saved second helps 馃憤

@LukasTy LukasTy merged commit 7424bae into mui:master Apr 4, 2024
18 checks passed
@LukasTy LukasTy deleted the limit-test-types-memory branch April 4, 2024 05:15
joakimtveter pushed a commit to joakimtveter/mui-x that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants