Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Fix server-side filter demo not working #12662

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

MBilalShafi
Copy link
Member

Fixes #12661

We updated the signature of ApplyFilterFunction in this PR but didn't update it in useQuery. In v7, when we removed the legacy filter, the demo started to break.

I first spotted and fixed it in #12317, but a separate fix would be better.

@MBilalShafi MBilalShafi added bug 🐛 Something doesn't work docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! labels Apr 3, 2024
@MBilalShafi MBilalShafi changed the title [DataGrid] Fix server-side filtering demo not working [DataGrid] Fix server-side filter demo not working Apr 3, 2024
@MBilalShafi MBilalShafi requested a review from romgrk April 3, 2024 17:58
@MBilalShafi MBilalShafi marked this pull request as ready for review April 3, 2024 17:58
@mui-bot
Copy link

mui-bot commented Apr 3, 2024

Deploy preview: https://deploy-preview-12662--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 45fb8cf

@MBilalShafi MBilalShafi merged commit d605f86 into mui:master Apr 4, 2024
12 of 15 checks passed
@MBilalShafi MBilalShafi deleted the fix-server-side-filter branch April 5, 2024 11:51
joakimtveter pushed a commit to joakimtveter/mui-x that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataGrid] Server-side filter demo not working
3 participants