[support-infra] Fix user permission check #12669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelengelen
added
the
scope: infra
|
Deploy preview: https://deploy-preview-12669--material-ui-x.netlify.app/ |
LukasTy
approved these changes
Apr 4, 2024
oliviertassinari
changed the title
|
Great, thanks for the fix 🙌 |
joakimtveter
pushed a commit
to joakimtveter/mui-x
that referenced
this pull request
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11784 (comment)
the default username that gets checked is the one that triggered the state change (closed the issue), but for this we need to check if the user that opened the issue has the required permissions.
It also fixes the result check to use booleans