-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charts] Fix Scatter series highlight when id is a number
#12677
[charts] Fix Scatter series highlight when id is a number
#12677
Conversation
Deploy preview: https://deploy-preview-12677--material-ui-x.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The solution looks good.
While looking at your solution, I was thinking that maybe I made a mistake by mixing the series and the delaunay in the same ref.
What do you think about splitting them into two distinct refs. One for the series and one for the delaunay, such that the isSeries
would not be necessary?
Makes sense, I thought about that, but imagined there was a reason for it being this way. And since I still don't have a lot of context on the repo I decided to leave it as I had found it. 😅 |
c5ba678
to
9f9b475
Compare
9f9b475
to
83ff373
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice code improvement 👍
Issue was due to
Object.keys()
returning an array of strings even if the keys are numbers.This fix stores the
seriesId
as a property inside the series object to avoid the issue mentioned above.Fixes #12603