Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Do not use import of depth 3 in the doc #12716

Merged
merged 1 commit into from
Apr 9, 2024
Merged

[docs] Do not use import of depth 3 in the doc #12716

merged 1 commit into from
Apr 9, 2024

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Apr 9, 2024 •
edited

fixes #12715

Issue caught by @joserodolfofreitas
The demo was broken when used in Stackblitz

@flaviendelangle flaviendelangle added docs Improvements or additions to the documentation component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! labels Apr 9, 2024
@flaviendelangle flaviendelangle self-assigned this Apr 9, 2024
@mui-bot
Copy link

mui-bot commented Apr 9, 2024

Deploy preview: https://deploy-preview-12716--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 4d73073

LukasTy
LukasTy approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
However, I feel that we need to fix eslint rules to catch these problems in docs preemptively. 🙈

@flaviendelangle
Copy link
Member Author

However, I feel that we need to fix eslint rules to catch these problems in docs preemptively.

100%

@flaviendelangle flaviendelangle merged commit 3120d68 into mui:master Apr 9, 2024
17 checks passed
@flaviendelangle flaviendelangle deleted the docs-invalid-import branch April 9, 2024 11:42
@mnathsnyk mnathsnyk mentioned this pull request May 15, 2024
Open
joakimtveter pushed a commit to joakimtveter/mui-x that referenced this pull request Jun 6, 2024
@flaviendelangle @joakimtveter
[docs] Do not use import of depth 3 in the doc (mui#12716)
293468d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

@joserodolfofreitas joserodolfofreitas Awaiting requested review from joserodolfofreitas

@michelengelen michelengelen Awaiting requested review from michelengelen

Assignees

@flaviendelangle flaviendelangle

Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TreeView] useTreeItem2Utils misses context and breaks demo on stackblitz
3 participants
@flaviendelangle @mui-bot @LukasTy