[TreeView] Remove state.items.itemTree
#12717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
the
component: tree view
flaviendelangle
commented
Apr 9, 2024
| id, | ||
| children, | ||
| }: TreeViewItemIdAndChildren): ReturnType<typeof instance.getItemsToRender>[number] => { | ||
| const getItemsToRender = React.useCallback(() => { |
There was a problem hiding this comment.
The useCallback was not needed since we call this function on every render
There was a problem hiding this comment.
but you added it anyways? Am I misunderstanding something? 🤯
There was a problem hiding this comment.
I read the change backward, fixed 😬
|
Deploy preview: https://deploy-preview-12717--material-ui-x.netlify.app/ |
flaviendelangle
changed the title
state.items.itemTree
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #12213, I noticed that
itemTreewas now totally redundant withorderedItemChildren.