[charts] Export more utils #12744
Merged
[charts] Export more utils #12744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
added
the
component: charts
|
Deploy preview: https://deploy-preview-12744--material-ui-x.netlify.app/ |
alexfauquette
force-pushed
the
export-more-hooks
branch
from
91e857a
to
7d322fd
Compare
JCQuintas
reviewed
Apr 11, 2024
JCQuintas
reviewed
Apr 11, 2024
I was thinking about adding those tools on demand, and in a few months creating a docs page about how to create your own sub-components, because documenting each hook independently does not make that much sense |
JCQuintas
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12702
I'm adding:
useSvgRefto let user access the SVG component easily from custom sub componentsunstable_useSeriesto get access to the series after all the internal transformation. This is marked as unstable because I'm not sure the series processing will stay stable, so it might be modifiedgetPieCoordinatesto let user compute like we do the basic information about the pie rendering base on the chart state.useChartIdthat get the chart id. It's a unique id generated to identify the chart when there are multiple ones in a same pageI also modify the codebase to use those hooks