Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add demo for styling charts with sx props #12791

Merged
merged 4 commits into from Apr 19, 2024

Conversation

derek-0000
Copy link
Contributor

Issue: #12633

Result:
image

@derek-0000 derek-0000 changed the title [docs] Added demo for styling charts with sx props [docs] Add demo for styling charts with sx props Apr 15, 2024
@mui-bot
Copy link

mui-bot commented Apr 15, 2024

Deploy preview: https://deploy-preview-12791--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 81fb99e

@zannager zannager added docs Improvements or additions to the documentation component: charts This is the name of the generic UI component, not the React module! labels Apr 16, 2024
@alexfauquette
Copy link
Member

alexfauquette commented Apr 19, 2024

Thanks for this nice example. For info, you can only write the tsx file and run the yarn docs:typescript:formatted command to generate the js one.

I modified a bit the sx to use the theme such that the demo adapt on the light/dark theme.

image

image

sx={(theme) => ({ ....  })}

If it's ok for you, wen merge 👍

@derek-0000
Copy link
Contributor Author

Thanks for the feedback. The end result looks great!

@alexfauquette alexfauquette merged commit 4b82c29 into mui:master Apr 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants