Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[charts] Fix passing slot props down to PieArcLabel #12806

Merged
merged 1 commit into from Apr 17, 2024
Merged

[charts] Fix passing slot props down to PieArcLabel #12806

merged 1 commit into from Apr 17, 2024

Conversation

JCQuintas
Copy link
Member

Fixes #12756

@JCQuintas JCQuintas added bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module! labels Apr 16, 2024
@JCQuintas JCQuintas marked this pull request as ready for review April 16, 2024 21:22
@mui-bot
Copy link

mui-bot commented Apr 16, 2024

Deploy preview: https://deploy-preview-12806--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against e9bdeaf

alexfauquette
alexfauquette approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JCQuintas JCQuintas merged commit aaa02d6 into mui:master Apr 17, 2024
19 checks passed
@JCQuintas JCQuintas deleted the 12756-charts-slots-for-piearclabelplot-defined-in-piearclabelplotslots-but-never-passed-down-from-piechart branch April 17, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[charts] slots for PieArcLabelPlot defined in PieArcLabelPlotSlots but never passed down from PieChart
3 participants
@JCQuintas @mui-bot @alexfauquette