Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TreeView] Support defaultMuiPrevented on the onFocus prop of the root slot #12813

Merged
merged 2 commits into from Apr 18, 2024

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Apr 17, 2024

This is clearly a nitpick but let's be consistent 👌
Unless I'm missing some prop, we now support defaultMuiPrevented on all the props of the Tree View components and TreeItem2 (not the legacy TreeItem).

@flaviendelangle flaviendelangle added the component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! label Apr 17, 2024
@flaviendelangle flaviendelangle self-assigned this Apr 17, 2024
@@ -110,6 +110,13 @@ export const useTreeViewJSXItems: TreeViewPlugin<UseTreeViewJSXItemsSignature> =
};
};

const isItemExpandable = (reactChildren: React.ReactNode) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related, this function was not using its scope

@mui-bot
Copy link

mui-bot commented Apr 17, 2024

Deploy preview: https://deploy-preview-12813--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against d557ffa

@flaviendelangle flaviendelangle marked this pull request as ready for review April 17, 2024 15:58
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@flaviendelangle flaviendelangle merged commit de60920 into mui:master Apr 18, 2024
17 checks passed
@flaviendelangle flaviendelangle deleted the misc-tree-view branch April 18, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants