Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Derive formattedValue from the edit value when passing to renderEditCell #12870

Merged
merged 1 commit into from
Apr 29, 2024
Merged

[DataGrid] Derive formattedValue from the edit value when passing to renderEditCell #12870

merged 1 commit into from
Apr 29, 2024

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Apr 22, 2024 •
edited

@cherniavskii cherniavskii added component: data grid This is the name of the generic UI component, not the React module! feature: Editing Related to the data grid Editing feature customization: extend Logic customizability enhancement This is not a bug, nor a new feature labels Apr 22, 2024
@mui-bot
Copy link

mui-bot commented Apr 22, 2024

Deploy preview: https://deploy-preview-12870--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 32365e3

@cherniavskii cherniavskii mentioned this pull request Apr 23, 2024
Closed
@cherniavskii cherniavskii marked this pull request as ready for review April 23, 2024 07:46
michelengelen
michelengelen approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cherniavskii cherniavskii merged commit c0b6932 into mui:master Apr 29, 2024
21 checks passed
@cherniavskii cherniavskii deleted the formattedValue-editing branch April 29, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBilalShafi MBilalShafi MBilalShafi approved these changes

@michelengelen michelengelen michelengelen approved these changes

@romgrk romgrk Awaiting requested review from romgrk

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! customization: extend Logic customizability enhancement This is not a bug, nor a new feature feature: Editing Related to the data grid Editing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] formattedValue not based on edited value in renderEditCell
4 participants
@cherniavskii @mui-bot @MBilalShafi @michelengelen