[docs] adjusted the code example for quickFilterValues #12919
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelengelen
added
docs
|
Deploy preview: https://deploy-preview-12919--material-ui-x.netlify.app/ Updated pages: |
MBilalShafi
approved these changes
Apr 28, 2024
| @@ -19,7 +19,7 @@ The quick filter values can be initialized by setting the `filter.filterModel.qu | |||
| filter: { | |||
| filterModel: { | |||
| items: [], | |||
| quickFilterValues: ['quick', 'filter'], | |||
| quickFilterValues: ['ab'], | |||
There was a problem hiding this comment.
Should we still somehow reinforce that quickFilterValues is of type string[] and spaces in quick filter are used as delimiter to generate this array (which will somehow get hidden by this change)?
There was a problem hiding this comment.
sry for the late reply. 🙇🏼
Maybe we could also use a more static dataset like the movie data.
Randomized row values could potentially lead to empty results when we initialize them.
WDYT @MBilalShafi ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjusted the value in the code example to represent what is shown in the example
Fixes #12912