Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[charts][PieChart] Fix prop.slots and prop.slotProps not passed to <ChartsTooltip /> #12939

Merged
merged 1 commit into from Apr 30, 2024
Merged

[charts][PieChart] Fix prop.slots and prop.slotProps not passed to <ChartsTooltip /> #12939

merged 1 commit into from Apr 30, 2024

Conversation

JCQuintas
Copy link
Member

@JCQuintas JCQuintas commented Apr 29, 2024 •
edited

@JCQuintas JCQuintas added bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module! labels Apr 29, 2024
@mui-bot
Copy link

mui-bot commented Apr 29, 2024

Deploy preview: https://deploy-preview-12939--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 78c2645

@JCQuintas JCQuintas changed the title [charts] Fix slots and slotProps not working with tooltip in piecharts [charts][PieChart] Fix prop.slots and prop.slotProps not passed to <ChartsTooltip /> Apr 29, 2024
tonytino
tonytino approved these changes Apr 29, 2024
View reviewed changes
Copy link

@tonytino tonytino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @JCQuintas!

LukasTy
LukasTy approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@JCQuintas JCQuintas merged commit 0ae7e4b into mui:master Apr 30, 2024
19 checks passed
@JCQuintas JCQuintas deleted the 12926-chartspiechart-propslots-and-propslotprops-not-passed-to-chartstooltip branch April 30, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

@tonytino tonytino tonytino approved these changes

@flaviendelangle flaviendelangle Awaiting requested review from flaviendelangle

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[charts][PieChart] prop.slots and prop.slotProps not passed to <ChartsTooltip />
4 participants
@JCQuintas @mui-bot @LukasTy @tonytino