Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Fix: column group change bug #12965

Merged
merged 5 commits into from
May 7, 2024

Conversation

romgrk
Copy link
Contributor

@romgrk romgrk commented May 1, 2024

@romgrk romgrk added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Column groups Related to the data grid Column groups feature labels May 1, 2024
@mui-bot
Copy link

mui-bot commented May 1, 2024

Deploy preview: https://deploy-preview-12965--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 45fa70e

@MBilalShafi
Copy link
Member

@romgrk Is it ok to review this one or do you want to check the failing tests first?

@romgrk romgrk marked this pull request as draft May 2, 2024 11:34
@romgrk romgrk marked this pull request as ready for review May 2, 2024 19:11
@romgrk
Copy link
Contributor Author

romgrk commented May 2, 2024

It's ready now.

@MBilalShafi MBilalShafi changed the title fix: column group change bug [DataGrid] Fix: column group change bug May 4, 2024
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't reproduce the issue anymore 👍
Apart from one minor suggestion that I added, it LGTM.

@romgrk romgrk enabled auto-merge (squash) May 6, 2024 16:29
@romgrk romgrk merged commit 1391342 into mui:master May 7, 2024
15 checks passed
@cherniavskii
Copy link
Member

Thanks for fixing it, I think I experienced the same issue when working on pivoting 👍🏻

@romgrk romgrk deleted the fix-column-fields-undefined branch May 9, 2024 19:45
joakimtveter pushed a commit to joakimtveter/mui-x that referenced this pull request Jun 6, 2024
cherniavskii added a commit to cherniavskii/mui-x that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Column groups Related to the data grid Column groups feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data grid] Error when column groups change
4 participants