[core] Improve release process docs #12977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JCQuintas
commented
May 2, 2024
JCQuintas
commented
- Ensure script pushes a tag instead of branch
- Added announce merge freeze
- Added how to create changelog
- Added instruction in case publish fails
- Instruction on which package should be updated vs not. Codemod? Package without changes?
- Note about announcement, is it optional? When do we send and announcement?
|
Deploy preview: https://deploy-preview-12977--material-ui-x.netlify.app/ |
LukasTy
changed the title
LukasTy
reviewed
May 3, 2024
There was a problem hiding this comment.
Nice improvement! 👍
Thank you for taking care of it. 💯 💙
Note about announcement, is it optional? When do we send and announcement?
I would agree that we should at least mark this section as optional.
Lately, it's mostly up to @noraleonte and @joserodolfofreitas to decide when do we want an announcement and it's generation is no longer taken care by the card-generator. 🤔
michelengelen
approved these changes
May 3, 2024
|
with the changes suggested by @LukasTy that is! ^^ |
Co-authored-by: Lukas <llukas.tyla@gmail.com> Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
Co-authored-by: Lukas <llukas.tyla@gmail.com> Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
Co-authored-by: Lukas <llukas.tyla@gmail.com> Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
|
I'll be merging this and setup a reminder to talk about the open points in the future, thanks for the input |
joakimtveter
pushed a commit
to joakimtveter/mui-x
that referenced
this pull request
Jun 6, 2024
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com> Co-authored-by: Lukas <llukas.tyla@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.