Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Automation: Add release PR reviewers #12982

Merged

Conversation

michelengelen
Copy link
Member


adds an action to automatically request reviews from the x maintainers on a release PR

cc @JCQuintas :P

@michelengelen michelengelen self-assigned this May 3, 2024
@michelengelen michelengelen added enhancement This is not a bug, nor a new feature scope: infra Org infrastructure work going on behind the scenes labels May 3, 2024
@michelengelen michelengelen changed the title [code-infra] Automation: Add release PR reviewers [infra] Automation: Add release PR reviewers May 3, 2024
@mui-bot
Copy link

mui-bot commented May 3, 2024

Deploy preview: https://deploy-preview-12982--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 938b9b5

Co-authored-by: Jose C Quintas Jr <juniorquintas@gmail.com>
Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
# Tests that label is added on the PR
runs-on: ubuntu-latest
permissions:
contents: read
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably not going to work. 🙈
Have you checked cli/cli#7671? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting ... need to look into this ... thanks for pointing it out

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems promissing
cli/cli#4844 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the curl approach for the API, since the gh cli seemingly does not allow for passing in an array of strings 🤷🏼

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it might still fail as the suggestion here: cli/cli#4844 (comment) specifies the write permissions. 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah ... it did fail, but for another reason! :D

@michelengelen
Copy link
Member Author

I will try the new workflow with a dummy PR ... so expect notifications flying in!

@michelengelen michelengelen merged commit eea77d7 into mui:master May 3, 2024
17 checks passed
@michelengelen michelengelen deleted the automation/add-release-reviewers branch May 3, 2024 13:12
joakimtveter pushed a commit to joakimtveter/mui-x that referenced this pull request Jun 6, 2024
Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
Co-authored-by: Jose C Quintas Jr <juniorquintas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature scope: infra Org infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants