Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Fix Netlify PR preview path #12993

Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented May 4, 2024

I noticed this in #12992. Netlify PR preview JavaScript file loading is all broken 馃檲:

SCR-20240504-qgra

I got this wrong in #5594. We will move these docs to subdomains anyway https://www.notion.so/mui-org/docs-infra-Change-docs-domain-0ce329e7ebc34aba8fbf4f3c5e13eb5d but it's a quick win so why not fix it as well.

Before: https://deploy-preview-12991--material-ui-x.netlify.app/x/react-data-grid/
After: https://deploy-preview-12993--material-ui-x.netlify.app/x/react-data-grid/

@oliviertassinari oliviertassinari added scope: docs-infra Specific to the docs-infra product bug 馃悰 Something doesn't work performance regression A bug, but worse and removed bug 馃悰 Something doesn't work labels May 4, 2024
@mui-bot
Copy link

mui-bot commented May 4, 2024

Deploy preview: https://deploy-preview-12993--material-ui-x.netlify.app/

Generated by 馃毇 dangerJS against 7b60b77

oliviertassinari added a commit to mui/mui-toolpad that referenced this pull request May 4, 2024
oliviertassinari added a commit to mui/base-ui that referenced this pull request May 4, 2024
Copy link
Member

@JCQuintas JCQuintas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

odd that it was picking 301 instead 馃

@oliviertassinari
Copy link
Member Author

oliviertassinari commented May 6, 2024

301 is the default: https://docs.netlify.com/routing/redirects/redirect-options/#http-status-codes.

@oliviertassinari oliviertassinari merged commit b6c2938 into mui:master May 6, 2024
22 checks passed
@oliviertassinari oliviertassinari deleted the fix-load-speed-pr-preview branch May 6, 2024 13:17
joakimtveter pushed a commit to joakimtveter/mui-x that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance regression A bug, but worse scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants