Skip to content

[code-infra] Use nx for lerna tasks #13166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2024

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented May 17, 2024

Enable nx for lerna task orchestration.
Aligns the setup with other repositories.

There do not seem to be any clear performance issues with nx orchestration enabled.

With nx:

https://app.circleci.com/pipelines/github/mui/mui-x/58373/workflows/bbbc2903-3673-4ddd-80a6-2fdcd2b1e417

Current master:

https://app.circleci.com/pipelines/github/mui/mui-x/58366/workflows/e11633f2-759c-4f1b-b459-748cdc73fa14

Verified

This commit was signed with the committer’s verified signature.
LukasTy Lukas Tyla
@LukasTy LukasTy added the scope: code-infra Specific to the core-infra product label May 17, 2024
@LukasTy LukasTy self-assigned this May 17, 2024
@mui-bot
Copy link

mui-bot commented May 17, 2024

Deploy preview: https://deploy-preview-13166--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 4c05018

@LukasTy LukasTy requested review from a team May 17, 2024 13:45
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@LukasTy LukasTy merged commit d9d69c9 into mui:master May 17, 2024
18 checks passed
@LukasTy LukasTy deleted the use-nx-for-orchestration branch May 17, 2024 14:51
arthurbalduini pushed a commit to arthurbalduini/mui-x that referenced this pull request May 23, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024

Partially verified

This commit is signed with the committer’s verified signature. The key has expired.
thomasmoon’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants