Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[I10n] Add Japanese (ja-JP) locale to pickers #6365

Merged
merged 2 commits into from Oct 4, 2022
Merged

[I10n] Add Japanese (ja-JP) locale to pickers #6365

merged 2 commits into from Oct 4, 2022

Conversation

sho918
Copy link
Contributor

@sho918 sho918 commented Oct 3, 2022

Add japanese translations to pickers.

@mui-bot
Copy link

mui-bot commented Oct 3, 2022 •
edited

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 513.3 1,082.7 519.7 755.02 219.178
Sort 100k rows ms 673.1 1,344.4 673.1 982.24 267.653
Select 100k rows ms 149.6 294 268.5 243.72 50.318
Deselect 100k rows ms 126.9 216 198.7 184.28 31.33

Generated by 🚫 dangerJS against fd1f449

@sho918 sho918 marked this pull request as ready for review October 3, 2022 12:48
LukasTy
LukasTy requested changes Oct 4, 2022
View reviewed changes
packages/x-date-pickers/src/locales/jaJP.ts Outdated Show resolved Hide resolved
packages/x-date-pickers/src/locales/jaJP.ts Outdated Show resolved Hide resolved
@sho918 sho918 requested a review from LukasTy October 4, 2022 11:27
@LukasTy LukasTy added l10n localization component: pickers This is the name of the generic UI component, not the React module! labels Oct 4, 2022
@LukasTy LukasTy merged commit 7afabe5 into mui:next Oct 4, 2022
LukasTy pushed a commit to LukasTy/mui-x that referenced this pull request Oct 4, 2022
@sho918 @LukasTy
[l10n] Add Japanese (ja-JP) locale to pickers (mui#6365)
53c1bc4
@LukasTy LukasTy mentioned this pull request Oct 4, 2022
Merged
LukasTy added a commit that referenced this pull request Oct 4, 2022
@LukasTy @sho918
[l10n] Add Japanese (ja-JP) locale to pickers (#6365) (#6382)
a35e8ed 
Co-authored-by: Arai Shota <me@arsho.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

Assignees
No one assigned
Labels
component: pickers This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sho918 @mui-bot @LukasTy