Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Don't start edit mode when pressing Shift + Space #6380

Merged
merged 1 commit into from Oct 4, 2022
Merged

[DataGrid] Don't start edit mode when pressing Shift + Space #6380

merged 1 commit into from Oct 4, 2022

Conversation

m4theushw
Copy link
Member

Backport of #6228

@m4theushw m4theushw added the component: data grid This is the name of the generic UI component, not the React module! label Oct 4, 2022
@mui-bot
Copy link

mui-bot commented Oct 4, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 464.2 883.3 705.9 659.26 167.444
Sort 100k rows ms 561.1 970.5 918.7 814.18 170.924
Select 100k rows ms 178.9 297.3 211.4 223.46 39.403
Deselect 100k rows ms 124.9 319 173.2 190.44 66.871

Generated by 🚫 dangerJS against 17e695f

@m4theushw m4theushw changed the title [DataGrid] Don't start edit mode when pressing Shift + Space (#6228) [DataGrid] Don't start edit mode when pressing Shift + Space Oct 4, 2022
@m4theushw m4theushw merged commit ffebf48 into mui:master Oct 4, 2022
@m4theushw m4theushw deleted the shift-space-editing-v5 branch October 4, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m4theushw @mui-bot