Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Add missing valueOptions #6400

Merged
merged 1 commit into from Oct 6, 2022
Merged

[DataGrid] Add missing valueOptions #6400

merged 1 commit into from Oct 6, 2022

Conversation

DanailH
Copy link
Member

@DanailH DanailH commented Oct 6, 2022 •
edited by cherniavskii

@DanailH DanailH added the bug 🐛 Something doesn't work label Oct 6, 2022
@DanailH DanailH self-assigned this Oct 6, 2022
@mui-bot
Copy link

mui-bot commented Oct 6, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 483.7 805.4 738.7 656.1 139.033
Sort 100k rows ms 568.6 1,826.3 568.6 1,039.18 427.349
Select 100k rows ms 187.5 753 272.6 357.62 202.817
Deselect 100k rows ms 148.7 290.2 191.1 198.38 51.772

Generated by 🚫 dangerJS against 810bcf4

@DanailH DanailH marked this pull request as ready for review October 6, 2022 12:03
@DanailH DanailH merged commit 52a18d5 into mui:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

@cherniavskii cherniavskii cherniavskii approved these changes

@MBilalShafi MBilalShafi Awaiting requested review from MBilalShafi

Assignees

@DanailH DanailH

Labels
bug 🐛 Something doesn't work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DanailH @mui-bot @flaviendelangle @cherniavskii